Add DistinctCountSketch meter#131
Open
brharrington wants to merge 1 commit into
Open
Conversation
Adds a distinct count sketch client that estimates the number of distinct values seen during a step interval using a HyperLogLog sketch, matching the spectator-java and spectatord implementations so sketches merge correctly. Uses the 's' precomputed-hash line type: the client computes the xxHash64 (seed 0) of the value locally via github.com/cespare/xxhash/v2 and sends 's:name,tags:<hash>' to SpectatorD, which derives the registers. Integers are hashed as their 8-byte little-endian representation and strings as their UTF-8 bytes, matching the other clients. Provides RecordString, RecordBytes, and RecordInt64. Wires the meter into the Registry interface and implementation (DistinctCountSketch and DistinctCountSketchWithId), and pulls in the shared cross-language test vector file with a test that verifies the hash and the emitted line against it for every vector input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a distinct count sketch client that estimates the number of distinct values seen during a step interval using a HyperLogLog sketch, matching the spectator-java and spectatord implementations so sketches merge correctly.
Uses the 's' precomputed-hash line type: the client computes the xxHash64 (seed 0) of the value locally via github.com/cespare/xxhash/v2 and sends 's:name,tags:' to SpectatorD, which derives the registers. Integers are hashed as their 8-byte little-endian representation and strings as their UTF-8 bytes, matching the other clients. Provides RecordString, RecordBytes, and RecordInt64.
Wires the meter into the Registry interface and implementation (DistinctCountSketch and DistinctCountSketchWithId), and pulls in the shared cross-language test vector file with a test that verifies the hash and the emitted line against it for every vector input.