Fix UDS writer flush() to reset buffer synchronously#126
Merged
Conversation
mason-albert
force-pushed
the
masona/fix-flush
branch
from
June 2, 2026 01:07
00459d5 to
e9888eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UdsWriter.flush()deferred the buffer reset onto a chained microtask, which could let repeated writes past_maxBufferBytesqueue duplicatedrainBuffercalls. In NQ canaries, this may have become a microtask flood that pins a CPU at 100%. MirrorUdpWriter's pattern by snapshotting the payload synchronously inflush()/close()before chaining the send.NodeQuark canaries on UDS pin at 100% CPU 5-30 min after startup with no consistent trigger, I'd be curious to see if canaries with this change show any improvement