python/config: make download_reactively race-safe under parallel exec…#1534
Merged
Conversation
…ution download_reactively() invokes urllib.request.urlretrieve(remote_path, local_path) which writes incrementally to local_path. Concurrent processes that share the same fixture cache (e.g. pytest-xdist workers) check os.path.exists(local_path) and short-circuit, but between the moment urlretrieve creates the file and the moment it finishes writing, the file exists and is partial. A second worker that arrives in that window opens local_path, reads garbage, and proceeds. For YUV fixtures consumed by feature extractors, the visible failure is non-deterministic feature scores -- the same test produces different actuals on different runs. Fix: download into a sibling tempfile via tempfile.mkstemp() then os.replace() onto local_path. os.replace() is atomic on POSIX, so concurrent writers can only ever overwrite a complete file with another complete file; readers never observe a partial file. The unique sibling name (mkstemp suffix) also prevents a second race between two workers writing to the same tempfile. Behaviour preserved: - same early-return when local_path already exists, - same os.makedirs(parent, exist_ok=True), - same urllib.error.HTTPError handling and re-raise. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ution
download_reactively() invokes urllib.request.urlretrieve(remote_path, local_path) which writes incrementally to local_path. Concurrent processes that share the same fixture cache (e.g. pytest-xdist workers) check os.path.exists(local_path) and short-circuit, but between the moment urlretrieve creates the file and the moment it finishes writing, the file exists and is partial. A second worker that arrives in that window opens local_path, reads garbage, and proceeds. For YUV fixtures consumed by feature extractors, the visible failure is non-deterministic feature scores -- the same test produces different actuals on different runs.
Fix: download into a sibling tempfile via tempfile.mkstemp() then os.replace() onto local_path. os.replace() is atomic on POSIX, so concurrent writers can only ever overwrite a complete file with another complete file; readers never observe a partial file. The unique sibling name (mkstemp suffix) also prevents a second race between two workers writing to the same tempfile.
Behaviour preserved: