Perform rendering in a fully depth-first manner. #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theengineear
force-pushed
the
fully-depth-first-render
branch
from
0253287 to
490a273
Compare
theengineear
commented
Nov 8, 2024
| state.result = result; | ||
| TemplateEngine.#ready(result); | ||
| TemplateEngine.#commit(result); | ||
| TemplateEngine.#inject(result, container); |
Collaborator
Author
There was a problem hiding this comment.
The above three lines sum up the change neatly. Before, we readied / injected in one line… then committed the update. Now, we ready, commit, and lastly inject.
Yes, in the future we will change all these internal method names… not now though.
Currently, we inject dom into our container and then update bindings. This causes all child “connectedCallback” calls to fire _before_ we bind property / attribute / etc. updates. That’s problematic because elements have no good way to observe initial deltas in the render tree. Said another way… We used to do this: 1. Create new nodes and inject new nodes into our container. 2. Bind value updates to new nodes. Now we do this: 1. Create new nodes. 2. Bind value updates to new nodes. 3. Inject new nodes into our container. Closes #197.
theengineear
force-pushed
the
fully-depth-first-render
branch
from
490a273 to
a1a3cd6
Compare
Collaborator
Author
|
FYI, no obvious performance change here (which is to be expected). It’s really just changing the order in which we do the exact same things. |
Collaborator
Author
|
@klebba — As a back-burner task, I try to take a moment every once and a while to kick the tires on the default template engine. Here’s an interesting bug I found / fixed today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we inject dom into our container and then update bindings. This causes all child “connectedCallback” calls to fire before we bind property / attribute / etc. updates.
That’s problematic because elements have no good way to observe initial deltas in the render tree. Said another way…
We used to do this:
Now we do this:
Closes #197.