Ditch Deprecated Directives (e.g., “ifDefined”). #335
Merged
+12
−536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theengineear
commented
Dec 3, 2025
| }); | ||
| }); | ||
|
|
||
| describe('html updaters', () => { |
Collaborator
Author
There was a problem hiding this comment.
If you are wondering, “yes” — we had previously refactored the whole test suite so that this eventual removal would be this clean :^)
theengineear
commented
Dec 3, 2025
| // the parser is _very_ strict, we can make a lot of simplifying assumptions. | ||
| static #onToken( | ||
| // These areguments are passed in through a “bind”. | ||
| // These arguments are passed in through a “bind”. |
Collaborator
Author
There was a problem hiding this comment.
Fixing a tyop.
theengineear
force-pushed
the
ditch-deprecated-directives
branch
2 times, most recently
from
87a4b52 to
1223ece
Compare
theengineear
changed the title
theengineear
force-pushed
the
ditch-deprecated-directives
branch
from
1223ece to
9a5755d
Compare
Collaborator
Author
* Removes “ifDefined” (previously just deprecated). * Removes “repeat” (previously just deprecated). * Removes some “future state” commentary (cleanup). Closes #336.
theengineear
force-pushed
the
ditch-deprecated-directives
branch
from
9a5755d to
0a0fd46
Compare
Contributor
|
Very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #336.