Remove custom template engine support. #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theengineear
commented
Dec 3, 2025
| @@ -1,4 +1,4 @@ | |||
| import * as defaultTemplateEngine from './x-template.js'; | |||
| import { html, render } from './x-template.js'; | |||
Collaborator
Author
There was a problem hiding this comment.
No need to import as defaultTemplateEngine anymore — there is no confusion. We always mean our internal html and render when we are referencing it.
theengineear
commented
Dec 3, 2025
| * @param {{[key: string]: (...args: unknown[]) => unknown}} engine | ||
| * @returns {templateCallback} | ||
| */ | ||
| static template(html, engine) { // eslint-disable-line no-unused-vars |
Collaborator
Author
There was a problem hiding this comment.
This is probably the highlight of the change. The default template engine doesn’t have special directives anymore and now that you cannot plug in other engines — we can remove this parameter entirely. This seems small, but it’s an important reduction in surface area.
The ability to override `templateEngine` and use alternative rendering engines has been removed. The `x-element` class now uses `x-template` exclusively, which simplifies the codebase and reduces surface area. Changes: - Removes `defaultTemplateEngine` and `templateEngine` static getters. - Updates `template()` method signature to remove `engine` parameter. - Imports `html` and `render` directly from `x-template`. - Removes related demos. - Updates documentation to remove customization examples. - Removes related tests. Closes #337.
theengineear
force-pushed
the
remove-custom-template-engine
branch
from
c48b445 to
c1a0281
Compare
Collaborator
Author
Contributor
|
NOICE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to override
templateEngineand use alternative rendering engines has been removed. Thex-elementclass now usesx-templateexclusively, which simplifies the codebase and reduces surface area.Changes:
defaultTemplateEngineandtemplateEnginestatic getters.template()method signature to removeengineparameter.htmlandrenderdirectly fromx-template.Closes #337.