Use “npm-publish” environment to publish to NPM. #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theengineear
commented
Dec 4, 2025
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v3 | ||
| - uses: actions/checkout@v6 |
Collaborator
Author
There was a problem hiding this comment.
Doing some due diligence.
theengineear
commented
Dec 4, 2025
| with: | ||
| node-version: '22.14' | ||
| registry-url: 'https://registry.npmjs.org' | ||
| - run: npm ci |
Collaborator
Author
There was a problem hiding this comment.
I think this was probably just copied at one point. This project doesn’t even have production dependencies and it has no build… so I don’t know why we’d need to run npm ci. This should theoretically reduce attack vector surface area, fwiw.
theengineear
commented
Dec 4, 2025
| jobs: | ||
| main: | ||
| runs-on: ubuntu-latest | ||
| environment: npm-publish |
Collaborator
Author
There was a problem hiding this comment.
Key change: We now run this action within an assumed environment (yet to be created). It’s called npm-publish here to differentiate between other ways we publish (e.g., JSR). I.e., publish did not feel sufficient enough.
wesleytodd
previously approved these changes
Dec 4, 2025
theengineear
force-pushed
the
use-github-environment
branch
from
8d4093a to
831c2ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this improves our security as it relates to publishing to NPM from GitHub. These changes relate to #326.
Additionally:
npm ciduring publish, it’s a known attack vector and we shouldn’t actually need it in our no-build repository.