Improve TypeScript discovery on import. #342
Conversation
| "/x-template.js", | ||
| "/demo", | ||
| "/test", | ||
| "/etc", |
There was a problem hiding this comment.
This doesn’t exist anymore — just cleanup.
theengineear
force-pushed
the
improve-typescript-discovery
branch
from
642ad41 to
84ea994
Compare
| "default": "./x-element.js" | ||
| }, | ||
| "./x-element.js": { | ||
| "types": "./types/x-element.d.ts", |
There was a problem hiding this comment.
This is the same pattern we use in x-test for the same reason.
| "/test", | ||
| "/etc", | ||
| "/ts" | ||
| "/types" |
There was a problem hiding this comment.
Renames this to /types — I believe it’s a more commonly-followed convention.
|
@klebba — Any opinions on this? Just trying to improve some “best practices” stuff to improve things for integrators. For context, I did this recently for x-test because I was integrating it within a TypeScript application to allow for better static test feedback when developing with AI. It was a nice (and easy) win to simply include the “types” pointer to hint TypeScript (and other tooling) to our |
Changes: - Adds “types” field to each import for improved type discovery. - Removes vestigial package contents from “files”. - Adds “.” (default) so `import '@netflix/x-element';` works. - Renames “/ts” >> “/types” (better-follows community conventions). Closes #341.
theengineear
force-pushed
the
improve-typescript-discovery
branch
from
84ea994 to
89dd800
Compare
|
Going to get this merged in as I don’t suspect there will be any pushback surrounding the TypeScript stuff. |
Changes:
import '@netflix/x-element';works.Closes #341.