-
Notifications
You must be signed in to change notification settings - Fork 17
Adds experimental “decorators” interface. #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Spent some time planning and implementing this (not going to push the implementation up just yet though). I think we could reasonably ship this as an experimental opt-in in I mention it a bunch in the “DECORATORS.md” document — but I really like how…
|
257e635 to
3f45720
Compare
The TC39 proposals for JavaScript decorators and decorator metadata have made their way to stage 3. The next step is for browsers to begin implementing. It is not an “if” anymore, it is a “when”. This means that it’s time for us to explore what ergonomic improvements might be unlocked by enabling interoperation with these new interfaces. Some important notes: - We could ship this now (only integrator code requires new syntax). - The new interface _should_ be more idiomatic. - We should be able to delete some invented concepts entirely. Closes #346.
3f45720 to
595cf86
Compare
| accessor #children; | ||
|
|
||
| static template(host) { | ||
| return html`<div>${host.#internalProperty}</div>`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here’s one example that is actually pretty amazing when you dig into it:
- We are accessing a property right on the
host. Which is the right mental model. - But, that property is completely integrated with the x-element machinery (e.g., invalidation, compute, reflect, observe, etc).
- And… just like you expect, you can access private members because we’re in the same lexical scope (i.e.,
host.#privateThingjust works like you would expect). - And perhaps most importantly… if you tell your IDE that
hostis of typeTestElement— you get all the intellisense. If it was an instance method… your IDE would do this completely for free, but we need to strike a delicate balance here.
| } | ||
|
|
||
| const { property, listener } = XElement; | ||
| export { XElement, property, listener, html }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even with a fair amount of extra commentary (which will be removed, tightened) — we ended up with fewer lines of code here. That makes some sense because we deleted the concept of the internal proxy and deleted the properties proxy.
And, we end up actually supporting more features without needed to try (e.g., you can pass listener options directly to the @listener decorator). Also (and we will want to talk about this) — inheritance kinda just works now — for example #foo declared on a parent class is truly independent of a #foo declared on a child class (just like you would expect in regular class inheritance). And, you don’t need to redeclare a public field1 in a child class to use it idiomatically.
The TC39 proposals for JavaScript decorators and decorator metadata have
made their way to stage 3. The next step is for browsers to begin
implementing. It is not an “if” anymore, it is a “when”.
This means that it’s time for us to explore what ergonomic improvements
might be unlocked by enabling interoperation with these new interfaces.
Some important notes:
Closes #346.