Skip to content

Update implementation details to be compatible with pypy2#142

Open
akaIDIOT wants to merge 7 commits into
mainfrom
feature/use-pypy2
Open

Update implementation details to be compatible with pypy2#142
akaIDIOT wants to merge 7 commits into
mainfrom
feature/use-pypy2

Conversation

@akaIDIOT

Copy link
Copy Markdown
Member

Using type() to create NotConfigured was done for pypy, which broke for pypy2. Using a proper class helps. This PR also ensures NotConfigured can be pickled and comes back as the same singleton-like instances.

@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown

Comparing median (lower is better) metric of benchmarks between this PR's target (63b97c5) and the HEAD of this PR (5dc48e7):

3.10 3.11 3.12 3.13 3.14 PyPy 3.10 PyPy 3.11
test_benchmark_get -1% +4% -5% -2% +2% -4% +2%
test_benchmark_get_dotted +2% +3% -4% -3% +5% +5% +2%
test_benchmark_getattr -1% -1% -1% -4% -0% -5% -1%
test_benchmark_getitem +2% +4% -4% -1% +3% -3% -3%
test_benchmark_getitem_dotted -1% +5% -1% -4% +6% +2% +2%
test_benchmark_init_full_overlap +2% +1% -6% +1% +0% -2% -2%
test_benchmark_init_no_overlap +3% +1% -5% -3% +2% -4% -1%
test_benchmark_init_partial_overlap +3% +2% -7% -3% -1% -3% -0%
test_benchmark_reference_chain -2% +2% -2% +2% -1% +2% -1%
test_benchmark_splat_args +1% +2% +1% +3% +1% +1% -5%
test_benchmark_spread_kwargs -1% +2% -2% -2% +2% +2% -1%

(This comment will be updated on subsequent pushes)

Comment thread confidence/models.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant