Skip to content

feat: implement erc20 streaming #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

feat: implement erc20 streaming #237

wants to merge 10 commits into from

Conversation

Naomi-Gift
Copy link

@Naomi-Gift Naomi-Gift commented Jul 22, 2024 •
edited by julio4
Loading

Issue: Close #196

@Naomi-Gift

This comment was marked as off-topic.

Sign in to view
@Naomi-Gift
Copy link
Author

@julio4 can you take a look at this?

@Naomi-Gift Naomi-Gift marked this pull request as ready for review August 13, 2024 06:08
julio4
julio4 requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@julio4 julio4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but some improvements.
Todo:

  • write the chapter page in src
  • update to last edition 2024_07

Sorry for the late review, @Gift-Naomi do you still want to work on it or I'll finish it

@Naomi-Gift
Copy link
Author

Looks good, but some improvements. Todo:

  • write the chapter page in src
  • update to last edition 2024_07

Sorry for the late review, @Gift-Naomi do you still want to work on it or I'll finish it

@julio4 Yes sir
I will continue working on it and make the necessary corrections

@julio4
Copy link
Member

julio4 commented Oct 3, 2024

Looks good, but some improvements. Todo:

  • write the chapter page in src
  • update to last edition 2024_07

Sorry for the late review, @Gift-Naomi do you still want to work on it or I'll finish it

@julio4 Yes sir I will continue working on it and make the necessary corrections

Perfect, thank you a lot!

@Naomi-Gift
Copy link
Author

@julio4 I have made the changes, can you review please .

julio4
julio4 requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@julio4 julio4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still some changes to make. Please take a few minutes to read and review all contribution guidelines! Thank you

@Naomi-Gift
Copy link
Author

@julio4 I have not gotten any review from you yet.

julio4
julio4 requested changes Oct 24, 2024
View reviewed changes
@Naomi-Gift
Copy link
Author

@julio4 Hi ser
I have made the reviewed changes.

julio4
julio4 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@julio4 julio4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I'll make the last minor changes myself before merging.

@Naomi-Gift
Copy link
Author

LGTM I'll make the last minor changes myself before merging.

@julio4 Alright sir, thanks

@julio4 julio4 changed the base branch from main to dev November 20, 2024 03:31
@julio4 julio4 force-pushed the dev branch 3 times, most recently from 4328222 to 9267ef0 Compare January 28, 2025 22:34
@julio4 julio4 force-pushed the dev branch 2 times, most recently from 52ddbeb to 0dffcc5 Compare February 8, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julio4 julio4 julio4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: ERC20 Token Streaming
2 participants
@Naomi-Gift @julio4