feat: Add scaffolding for proposer sending messages to P2P#2856
feat: Add scaffolding for proposer sending messages to P2P#2856
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2856 +/- ##
==========================================
- Coverage 72.29% 71.80% -0.49%
==========================================
Files 263 266 +3
Lines 28572 28782 +210
==========================================
+ Hits 20656 20668 +12
- Misses 6520 6723 +203
+ Partials 1396 1391 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
infrmtcs
force-pushed
the
dat/dispatcher
branch
2 times, most recently
from
422d104 to
471fc37
Compare
infrmtcs
force-pushed
the
dat/adapters
branch
2 times, most recently
from
43642b1 to
3ac714f
Compare
infrmtcs
force-pushed
the
dat/store
branch
5 times, most recently
from
00a82a7 to
2dd2c19
Compare
infrmtcs
force-pushed
the
dat/dispatcher
branch
2 times, most recently
from
6de7e25 to
42fe1fb
Compare
| for txBatch := range slices.Chunk(txStream, txBatchSize) { | ||
| if !yield(d.fromTransactions(txBatch)) { | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
At this point we have built the entire block right? So why bother breaking the txns into chunks?
There was a problem hiding this comment.
We may want to send out transactions in chunk even if we have everything. Imagine the case where there are 1000 transactions, we want to gradually broadcast them instead of building a big message of 1k transactions and then the receiver has to process 1k transactions at a time.
3 participants
No description provided.