Skip to content

Comments

feat: starknet 0.14.0 provide RECEIVED status from cache#2950

Merged
rodrodros merged 4 commits intomainfrom
feat/0.14.0-submitted-transactions-cache
Jul 4, 2025
Merged

feat: starknet 0.14.0 provide RECEIVED status from cache#2950
rodrodros merged 4 commits intomainfrom
feat/0.14.0-submitted-transactions-cache

Conversation

@EgeCaner
Copy link
Contributor

@EgeCaner EgeCaner commented Jul 2, 2025

As of Starknet version 0.14.0, the Feeder Gateway no longer returns the RECEIVED status.

This PR introduces an LRU cache with time-based expiration to support tracking the RECEIVED status.

Cache entries expire after their time-to-live (TTL) elapses and are considered invalid.
Expired entries are evicted first.
If all entries are still valid, eviction is based on the least-recently-used (LRU) policy.

@EgeCaner EgeCaner mentioned this pull request Jul 2, 2025
@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 82.23684% with 27 lines in your changes missing coverage. Please review.

Project coverage is 72.26%. Comparing base (f950632) to head (fe5f2ab).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rpc/v6/transaction.go 76.00% 11 Missing and 1 partial ⚠️
rpc/v7/transaction.go 0.00% 7 Missing and 1 partial ⚠️
rpc/rpccore/submitted_transaction_cache.go 88.63% 5 Missing ⚠️
rpc/v8/transaction.go 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2950      +/-   ##
==========================================
+ Coverage   72.19%   72.26%   +0.07%     
==========================================
  Files         262      263       +1     
  Lines       28368    28496     +128     
==========================================
+ Hits        20479    20593     +114     
- Misses       6496     6511      +15     
+ Partials     1393     1392       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@rianhughes rianhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to my small comments the PR LGTM

@EgeCaner EgeCaner force-pushed the feat/0.14.0-submitted-transactions-cache branch from 158dfa8 to 9fc907e Compare July 3, 2025 14:53
@rianhughes rianhughes self-requested a review July 4, 2025 13:16
@rodrodros rodrodros merged commit 930c095 into main Jul 4, 2025
20 checks passed
@rodrodros rodrodros deleted the feat/0.14.0-submitted-transactions-cache branch July 4, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants