test(cbor): Populate golden cases for all structs the encoder handles

[RafaelGranza]

User description

Adds cases for every struct CBOR encodes in production, and its populated version.

The golden test also asserts the decoded value equals the expected struct, so the Go side is covered too.

No need to do the check bucket by bucket.

---

PR Type

Tests

---

Description

• Add populated golden cases for encoder structs

• Add transaction, state, journal, and metadata coverage

• Add expected CBOR bytes for new golden cases

---

File Walkthrough

Relevant files

Tests

golden_test.go Expand populated CBOR golden test cases                                    utils/cbor/v1/golden_test.go Import migration package for SchemaMetadata golden case Add populated golden cases for core, pathdb, and migration structs Add helper builders for transactions, classes, state, and journals Extend golden tests for encoder/decoder round-trip coverage +150/-0  on_disk_bytes.json Add expected CBOR bytes for new cases                                        utils/cbor/v1/testdata/on_disk_bytes.json Add expected serialized CBOR bytes for new golden cases Include transaction, StateUpdate, journal, and SchemaMetadata bytes Extend test data for populated struct assertions +13/-0

---

[github-actions]

Reviewing PR #4049

• Gather context (diff, files, repo conventions)
• Review golden_test.go for correctness/coverage
• Review testdata/on_disk_bytes.json changes
• Post findings

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🏅 Score: 90

🧪 PR contains tests

🔒 No security concerns identified

⚡ No major issues detected

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.17%. Comparing base (2b5452a) to head (8a32e4f).

Additional details and impacted files

@@                        Coverage Diff                         @@
##           refactor/encoder-to-utils-cbor    #4049      +/-   ##
==================================================================
- Coverage                           79.30%   79.17%   -0.13%     
==================================================================
  Files                                 465      465              
  Lines                               35786    35795       +9     
==================================================================
- Hits                                28381    28342      -39     
- Misses                               7396     7444      +48     
  Partials                                9        9              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Claude finished @RafaelGranza's task in 4m 55s —— View job

---

Reviewing PR #4049

• Gather context (diff, files, repo conventions)
• Review golden_test.go for correctness/coverage
• Review testdata/on_disk_bytes.json changes
• Post findings

Summary

Clean, no issues found.

This PR adds populated golden cases for the CBOR encoder/decoder covering DeclareTransaction, DeployTransaction, L1HandlerTransaction, DeployAccountTransaction, DeprecatedCairoClass, StateUpdate, and the pathdb journal types, alongside a handful of zero-value structs (L1Head, BlockCommitments, BlockTransactionsIndexes, migration.SchemaMetadata) that weren't previously covered at all.

Checked:

• Every populated struct literal (populatedDeclareTransaction, populatedDeployAccountTransaction, populatedStateUpdate, etc.) matches its type's actual field set in core/transaction.go, core/state_update.go, and core/trie2/triedb/pathdb/journal.go — no stale/renamed fields.
• The new migration import is actually used (migration.SchemaMetadata), not a stray import.
• TestGoldenBytes already asserts len(goldenCases()) == len(golden), so the new cases and the new on_disk_bytes.json entries stay in lock-step — no orphaned vectors possible.
• Round-trip coverage: the test doesn't just diff hex, it decodes each golden vector back via reflection and compares against the original struct (golden_test.go:346-348), so this also catches decode-side regressions, not just encode-side ones.
• CI's ubuntu-arm64-4-core "Run Tests" job has already completed successfully, confirming the golden vectors and round-trip assertions actually pass (not just eyeballed correct).

No correctness, concurrency, or resource-safety concerns — this is additive test-only content with no production code changes.

[github-actions]

Standalone PR Review

PR-Agent could not safely update the persistent review. This standalone result will not replace the canonical review.

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🏅 Score: 95

🧪 PR contains tests

🔒 No security concerns identified

⚡ No major issues detected