Implement EIP-5920: PAY #8382
Draft
Implement EIP-5920: PAY #8382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request implements EIP-5920 by introducing the PAY opcode into the EVM. Key changes include adding an IsEip5920Enabled flag in several spec interfaces and classes, registering the PAY opcode in the opcode lookup table, and providing a full PAY instruction implementation.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Nethermind/Nethermind.Specs/ReleaseSpec.cs | Added IsEip5920Enabled property. |
| src/Nethermind/Nethermind.Specs.Test/OverridableReleaseSpec.cs | Added forwarding of the IsEip5920Enabled flag. |
| src/Nethermind/Evm/Instructions/EvmInstructions.cs | Registers the PAY opcode when enabled. |
| src/Nethermind/Evm/Instructions/EvmInstructions.Call.cs | Implements the PAY instruction logic. |
| src/Nethermind/Evm/Instruction.cs | Adds PAY enum entry. |
| src/Nethermind/Core/Specs/ReleaseSpecDecorator.cs | Adds IsEip5920Enabled property for spec decoration. |
| src/Nethermind/Core/Specs/IReleaseSpec.cs | Introduces IsEip5920Enabled in the spec interface. |
Comments suppressed due to low confidence (1)
src/Nethermind/Nethermind.Evm/Instructions/EvmInstructions.Call.cs:417
- [nitpick] For consistency with other checks in the method, consider using !transferValue.IsZero instead of transferValue != 0.
else if (spec.ClearEmptyAccountWhenTouched && transferValue != 0 && state.IsDeadAccount(target))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eips.ethereum.org/EIPS/eip-5920
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?