fix eth_simulates minor issues #8452
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjnrohit
commented
Apr 1, 2025
src/Nethermind/Nethermind.Facade/Simulate/SimulateBridgeHelper.cs
Outdated
Show resolved
Hide resolved
LukaszRozmej
requested changes
Apr 1, 2025
| } | ||
|
|
||
| if (spec.IsEip4844Enabled) { | ||
| result.ParentBeaconBlockRoot = Keccak.Zero; |
There was a problem hiding this comment.
not Keccak.EmptyTreeHash?
| @@ -239,6 +239,10 @@ public void Encode(RlpStream rlpStream, BlockHeader? header, RlpBehaviors rlpBeh | |||
| { | |||
| rlpStream.Encode(header.BaseFeePerGas); | |||
| } | |||
| else if ((rlpBehaviors & RlpBehaviors.Simulate) == RlpBehaviors.Simulate) | |||
There was a problem hiding this comment.
Can we not include RlpBehaviors here but use a flag in constructor and use a non-default instance of decoder?
There was a problem hiding this comment.
Also we need to have the logic not to emit this when block is before EIP1559
Comment on lines
+35
to
+41
| /// <summary> | ||
| /// The `simulate` flag enables a special workaround for cases where `baseFeePerGas` is zero. | ||
| /// Technically, `baseFeePerGas` should never be zero, as it is required to be at least 7 or higher. | ||
| /// However, some execution clients, such as Geth, permit this edge case. | ||
| /// In such cases, we write `EmptyRlpByte` (0x80) to the byte array as a fallback. | ||
| /// </summary> | ||
| Simulate = 256, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.