Skip to content

Flatten blobs to reduce allocations and copies #8536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: feature/peerdas
Choose a base branch
from

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Apr 18, 2025

Open questions:

  • Should we change the code to use flat blobs?
  • Should we flatten both v0 and v1 proofs and endpoints

Probably it should be a separate pr unless it will seem critical to do this optimization right in the main one

@benaadams
Copy link
Member

Bunch of test errors?

  Failed Raw transaction in mempool form with accesslist, without to, non-trivial blobs [< 1 ms]
  Error Message:
   System.ArgumentException : Destination is too short. (Parameter 'destination')
  Stack Trace:
     at Nethermind.Serialization.Rlp.RlpStream.DecodeFlattenFixedByteArrays(Int32 itemLength) in /_/src/Nethermind/Nethermind.Serialization.Rlp/RlpStream.cs:line 1468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants