Skip to content

fix(Core): Implement IDisposable and add Disabled property to Progres… #8541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

avdheshcharjan
Copy link

Changes

  • Implement IDisposable on ProgressLogger to resolve CS1674 build errors when used in using statements.
  • Add static ProgressLogger.Disabled property to provide a no-op logger instance, resolving CS0117 build errors in tests.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

The changes resolve compile-time errors in existing tests that relied on the ProgressLogger.Disabled member. No new tests were added for the IDisposable implementation.

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@asdacap
Copy link
Contributor

asdacap commented Apr 21, 2025

Where is these error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants