Stellar lookup table#80
Closed
dkgoutham wants to merge 2 commits into
Closed
Conversation
dkgoutham
force-pushed
the
stellar-lookup-table
branch
from
June 18, 2026 03:49
f49451b to
e2158f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the Stellar core contract's handling of the address lookup scheme.
PR #76 added a
hash → Addressstorage registry (record_address/get_address_from_hash+ anAddressTablestorage key) to the core contract.The core contract has no
from/tofields and never reconstructs an addressfrom the wire, so that registry was orphaned — wired to nothing. This removes it
and keeps only the piece the core actually owns: the canonical
hash_addressprimitive.
The storage registry belongs in the NTT manager (the only place that resolves a
32-byte wire value back into a real
Address— the inbound recipient). It isimplemented there in a separate NTT PR.
hash_addressstays a pure function inthe shared
wormhole-soroban-clientcrate so the core contract, NTT, and theoff-chain SDK all compute the identical 32-byte identity.