add uninstall target to makefile #525
Merged
+43
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! |
|
Author did not disclose at the time, but this patch was one of hundreds he generated with an LLM. @rsmarples may I suggest reconsideration of the patch? One thing I noticed is that hooks/Makefile removes the binary and man pages. Other things look likely bad as well, but I am not going to do a line-by-line review of slop. |
Contributor
|
I would be very tempted to revert the commit. @rsmarples, what do you think? |
Member
|
I punted the patch from the top of the tree, like it never existed. Thanks all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uninstall