[ENH] Move to pyproject.toml#608
Open
Moritz-Alexander-Kern wants to merge 36 commits intoNeuralEnsemble:masterfrom
Open
[ENH] Move to pyproject.toml#608Moritz-Alexander-Kern wants to merge 36 commits intoNeuralEnsemble:masterfrom
Moritz-Alexander-Kern wants to merge 36 commits intoNeuralEnsemble:masterfrom
Conversation
added 12 commits
November 21, 2023 13:42
Collaborator
Member
Author
|
Editable install with
|
Member
Author
Moritz-Alexander-Kern
left a comment
There was a problem hiding this comment.
build wheels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves Elephant from setup.py to pyproject.toml, aligning with PEP 518.
Key changes include:
pyproject.tomlsetup.pyis still needed to compile the C-code for the fim module.The reason is that we need OS dependend compile args which are dynamically defined in
setup.py.The
pyproject.tomldoes not natively support conditional logic like os_name == 'windows' directly within the configuration. The TOML format is static and doesn't allow for dynamic evaluation of conditions based on the operating system.To achieve platform-specific compile arguments, we have to use a Python script, such as a
setup.py, which can programmatically determine the OS and apply the correct compile arguments.In this context, as a configuration file for setuptools,
setup.pyis not deprecated, see also: https://packaging.python.org/en/latest/discussions/setup-py-deprecated/