-
Notifications
You must be signed in to change notification settings - Fork 95
[ENH] Move to pyproject.toml #608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[ENH] Move to pyproject.toml #608
Conversation
|
Editable install with
|
Moritz-Alexander-Kern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build wheels
This PR moves Elephant from setup.py to pyproject.toml, aligning with PEP 518.
Key changes include:
pyproject.tomlsetup.pyis still needed to compile the C-code for the fim module.The reason is that we need OS dependend compile args which are dynamically defined in
setup.py.The
pyproject.tomldoes not natively support conditional logic like os_name == 'windows' directly within the configuration. The TOML format is static and doesn't allow for dynamic evaluation of conditions based on the operating system.To achieve platform-specific compile arguments, we have to use a Python script, such as a
setup.py, which can programmatically determine the OS and apply the correct compile arguments.In this context, as a configuration file for setuptools,
setup.pyis not deprecated, see also: https://packaging.python.org/en/latest/discussions/setup-py-deprecated/