Fix test_time_slice_deepcopy_data() failure on numpy 2.4.x#1849
Open
apdavison wants to merge 1 commit into
Open
Fix test_time_slice_deepcopy_data() failure on numpy 2.4.x#1849apdavison wants to merge 1 commit into
apdavison wants to merge 1 commit into
Conversation
numpy 2.4.x changed assert_array_compare, which in some circumstances causes a shape mismatch IndexError when comparing AnalogSignal objects, instead of the expected AssertionError. This change tests deepcopy more directly, by taking a snapshot of the object before mutation and asserting it is unchanged afterwards. Also add numpy 2.4.4 to the core-test CI matrix. Fixes NeuralEnsemble#1848
Member
Author
|
@sanjayankur31 can you take a look? |
|
Thanks for the quick fix @apdavison . Re-ran the tests and can confirm that this fixes the issue. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numpy 2.4.x changed
assert_array_compare, which in some circumstances causes a shape mismatch IndexError when comparing AnalogSignal objects, instead of the expected AssertionError.This change tests deepcopy more directly, by taking a snapshot of the object before mutation and asserting it is unchanged afterwards.
Also add numpy 2.4.4 to the core-test CI matrix.
Fixes #1848