Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Including Cross subject splitter #722

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

Including Cross subject splitter #722

wants to merge 20 commits into from

Conversation

bruAristimunha
Copy link
Collaborator

No description provided.

bruAristimunha
bruAristimunha commented Mar 9, 2025
View reviewed changes
@PierreGtch PierreGtch mentioned this pull request Mar 13, 2025
Open
@bruAristimunha bruAristimunha requested review from tomMoral and PierreGtch and removed request for tomMoral and PierreGtch March 23, 2025 21:31
PierreGtch
PierreGtch approved these changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@PierreGtch PierreGtch left a comment •
edited by bruAristimunha
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Thanks @bruAristimunha and @brunaafl !

@bruAristimunha bruAristimunha enabled auto-merge (squash) March 24, 2025 13:54
@bruAristimunha
Copy link
Collaborator Author

Thank you for the review @PierreGtch :)

tomMoral
tomMoral reviewed Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first batch of comments

@bruAristimunha bruAristimunha disabled auto-merge March 24, 2025 14:27
PierreGtch
PierreGtch approved these changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@PierreGtch PierreGtch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my points have been addressed, thanks @bruAristimunha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreGtch PierreGtch PierreGtch approved these changes

@tomMoral tomMoral Awaiting requested review from tomMoral

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bruAristimunha @tomMoral @PierreGtch