Skip to content

Fix bug automatic datapipe configuration #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented May 25, 2025

Motivation

This change fixes a failing test in PR #716.

In summary:
When applying a dataset configuration (PR #636), the DataPipe's maxSize was previously set automatically in the DataPipe constructor. Using that default behavior, vectors were mapped onto 2D datasets in file, because the maxSize was set to [Inf, n], respecting the 2D nature of MATLAB vectors. This change forces a vector to 1D by explicitly setting maxSize to [Inf] when creating a DataPipe for column- and row-vectors.

How to test the behavior?

Show here how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

Fixed bug where maxSize should be explicitly set for DataPipe vector data
@ehennestad ehennestad requested a review from bendichter May 29, 2025 12:39
@bendichter bendichter merged commit 8c16793 into 711-fix-datapipe-size-validation May 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants