Fix bug automatic datapipe configuration #717
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This change fixes a failing test in PR #716.
In summary:
When applying a dataset configuration (PR #636), the DataPipe's
maxSize
was previously set automatically in theDataPipe
constructor. Using that default behavior, vectors were mapped onto 2D datasets in file, because themaxSize
was set to [Inf, n], respecting the 2D nature of MATLAB vectors. This change forces a vector to 1D by explicitly settingmaxSize
to [Inf] when creating aDataPipe
for column- and row-vectors.How to test the behavior?
Checklist
fix #XX
whereXX
is the issue number?