Fix read for scalar compound dataset #761
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #759
Summary
If a scalar (
H5S_SCALAR) compound dataset contains booleans or references, currently parsing would not postprocess such values and they would be returned asint8.While working on this issue, I also realized that MatNWB would not export a compound scalar dataset using HDF5 scalar dataspace, instead it would create a simple dataspace with shape 1.
Looking at PyNWB, the scalar and compound dataset
ElectrodeGroup/positionis exported using a scalar dataspace.PR Changes:
io.parseCompoundinio.parseDatasetfor scalar (H5S_SCALAR) dataspace type.io.writeCompoundto export as scalar (H5S_SCALAR) if NWB dataset shape is scalar.How to test the behavior?
Todo
Checklist
fix #XXwhereXXis the issue number?