Skip to content

Commit 3299a2a

Browse files
rlystephprince
andauthored
Use ExternalImage.data instead of file_path (#623)
Co-authored-by: Steph Prince <[email protected]>
1 parent 0c7896b commit 3299a2a

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

core/nwb.base.yaml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,11 @@ datasets:
6464

6565
- neurodata_type_def: ExternalImage
6666
neurodata_type_inc: BaseImage
67-
doc: A type for referencing an external image file.
68-
attributes:
69-
- name: file_path
70-
dtype: text
71-
doc: Path or URL to the external image file.
72-
required: true
67+
doc: A type for referencing an external image file. The single file path or URL to the external image file should
68+
be stored in the dataset. This type should NOT be used if the image is stored
69+
in another NWB file and that file is linked to this file.
70+
dtype: text
71+
# shape: scalar # this will be supported in the NWB schema language 2.0
7372

7473
- neurodata_type_def: ImageReferences
7574
neurodata_type_inc: NWBData

docs/format/source/format_release_notes.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Release Notes
88

99
Major changes
1010
^^^^^^^^^^^^^
11-
- Added `BaseImage` and `ExternalImage` as new neurodata types. The first so both `Image` and `ExternalImage` can inherit from it. The second to store external images (#604)
11+
- Added `BaseImage` and `ExternalImage` as new neurodata types. The first so both `Image` and `ExternalImage` can inherit from it. The second to store external images (#604, #623)
1212

1313
Minor changes
1414
^^^^^^^^^^^^^

0 commit comments

Comments
 (0)