Skip to content

FrequencyBandsTable #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

FrequencyBandsTable #610

wants to merge 13 commits into from

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Mar 2, 2025

Summary of changes

  • ...

Checklist

For all schema changes:

  • Add release notes for the PR to docs/format/source/format_release_notes.rst.
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.
  • Make sure that hdmf-common-schema points to the latest release and not the latest commit on the main branch.

If this is the first schema change after a schema release (i.e., the version string in core/nwb.namespace.yaml does not
end in "-alpha"), then:

  • Update the version string in core/nwb.namespace.yaml and core/nwb.file.yaml to the next major/minor/patch
    version with the suffix "-alpha". For example, if the current version is 2.4.0 and this is a minor change, then the
    new version string should be "2.5.0-alpha".
  • Update the value of the version variable in docs/format/source/conf.py to the next version without the
    suffix "-alpha", e.g., "2.5.0".
  • Update the value of the release variable in docs/format/source/conf.py to the next version with the suffix
    "-alpha", e.g., "2.5.0-alpha".
  • Add a new section in the release notes docs/format/source/format_release_notes.rst for the new version
    with the date "Upcoming" in parentheses.

@rly
Copy link
Contributor

rly commented Apr 26, 2025

Could you please rename this to FrequencyBandsTable? "Bands" is very ambiguous.

@mavaylon1
Copy link
Contributor Author

Review Notes:
There is not "Fix open ticket"
This is not the first schema change.

@mavaylon1 mavaylon1 marked this pull request as ready for review April 30, 2025 22:39
@mavaylon1 mavaylon1 requested a review from rly April 30, 2025 22:39
@mavaylon1 mavaylon1 changed the title BandsTable FrequencyBandsTable Apr 30, 2025
@rly rly changed the base branch from dev to electrodes_table2 May 10, 2025 16:35
@rly rly mentioned this pull request May 10, 2025
Base automatically changed from electrodes_table2 to dev May 15, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants