Skip to content

Make group quantities consistent across data interfaces / wrapper types #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 19, 2025
Merged

Make group quantities consistent across data interfaces / wrapper types #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fddab7f
Change quantity for groups of wrapper types from * to +
ehennestad Mar 7, 2025
912acb6
Change quantity for groups of wrapper types from * to + in ecephys
ehennestad Mar 7, 2025
750bb30
Update format_release_notes.rst
ehennestad Mar 7, 2025
cec2b7a
Update format_release_notes.rst
ehennestad Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions core/nwb.behavior.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ groups:
groups:
- neurodata_type_inc: IntervalSeries
doc: IntervalSeries object containing start and stop times of epochs.
quantity: '*'
quantity: '+'

- neurodata_type_def: BehavioralEvents
neurodata_type_inc: NWBDataInterface
Expand All @@ -71,7 +71,7 @@ groups:
groups:
- neurodata_type_inc: TimeSeries
doc: TimeSeries object containing behavioral events.
quantity: '*'
quantity: '+'

- neurodata_type_def: BehavioralTimeSeries
neurodata_type_inc: NWBDataInterface
Expand All @@ -81,7 +81,7 @@ groups:
groups:
- neurodata_type_inc: TimeSeries
doc: TimeSeries object containing continuous behavioral data.
quantity: '*'
quantity: '+'

- neurodata_type_def: PupilTracking
neurodata_type_inc: NWBDataInterface
Expand All @@ -99,7 +99,7 @@ groups:
groups:
- neurodata_type_inc: SpatialSeries
doc: SpatialSeries object containing data measuring direction of gaze.
quantity: '*'
quantity: '+'

- neurodata_type_def: CompassDirection
neurodata_type_inc: NWBDataInterface
Expand All @@ -112,7 +112,7 @@ groups:
groups:
- neurodata_type_inc: SpatialSeries
doc: SpatialSeries object containing direction of gaze travel.
quantity: '*'
quantity: '+'

- neurodata_type_def: Position
neurodata_type_inc: NWBDataInterface
Expand Down
2 changes: 1 addition & 1 deletion core/nwb.ecephys.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ groups:
groups:
- neurodata_type_inc: SpikeEventSeries
doc: SpikeEventSeries object(s) containing detected spike event waveforms.
quantity: '*'
quantity: '+'

- neurodata_type_def: FilteredEphys
neurodata_type_inc: NWBDataInterface
Expand Down
1 change: 1 addition & 0 deletions docs/format/source/format_release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Major changes

Minor changes
^^^^^^^^^^^^^
- Made group quantities consistent ("1 or more") across data interfaces / wrapper types (#613)
- Fixed typo and removed HTML tag from doc of behavioral neurodata types. (#600)

2.8.0 (November 24, 2024)
Expand Down