Skip to content

Use ExternalImage.data instead of file_path #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2025
Merged

Use ExternalImage.data instead of file_path #623

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23ce825
Use ExternalImage.data instead of file_path
rly May 8, 2025
5105b00
Update format_release_notes.rst
rly May 8, 2025
276270f
Update core/nwb.base.yaml
rly May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions core/nwb.base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,10 @@ datasets:

- neurodata_type_def: ExternalImage
neurodata_type_inc: BaseImage
doc: A type for referencing an external image file.
attributes:
- name: file_path
dtype: text
doc: Path or URL to the external image file.
required: true
doc: A type for referencing an external image file. The single file path or URL to the external image file should
be stored in the dataset.
dtype: text
# shape: scalar # this will be supported in the NWB schema language 2.0

- neurodata_type_def: ImageReferences
neurodata_type_inc: NWBData
Expand Down
2 changes: 1 addition & 1 deletion docs/format/source/format_release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Release Notes

Major changes
^^^^^^^^^^^^^
- Added `BaseImage` and `ExternalImage` as new neurodata types. The first so both `Image` and `ExternalImage` can inherit from it. The second to store external images (#604)
- Added `BaseImage` and `ExternalImage` as new neurodata types. The first so both `Image` and `ExternalImage` can inherit from it. The second to store external images (#604, #623)

Minor changes
^^^^^^^^^^^^^
Expand Down
Loading