Updates to flask app and database updating #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
stephprince
commented
Sep 16, 2025
CodyCBakerPhD
approved these changes
Sep 17, 2025
Collaborator
|
Thanks for taking this on - feel free to merge whenever it's to your liking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor documentation and code changes that came up when trying to debug the database updating locally.
When debugging, I inadvertently pushed the latest results to the nwb-benchmarks-database GitHub repo - I updated the app script to skip pushing new files when in debug mode but let me know your thoughts on if we need any better protections.
From what I could tell, the
repackage_as_parquetfunction was not saving the values from the network tests - which are stored as a dictionary of several metrics with their associated values. I added an additional column / attribute to the results that saves the variable name of each metric (and in the case of the timing tests, uses the variable name "time")