Add local read/slice benchmarks, refactor params #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodyCBakerPhD
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #163
This also majorly refactors how params across benchmarks were handled because it was too easy to accidentally modify one parameter and not modify another one that should also be modified. Params are now handled in one file and generated programmatically from the dataset identifiers and either following redirects or not. It's still not the cleanest, but it is relatively simple and easy to modify. Happy to discuss if you can come up with a cleaner organization.
Also fix #166. The slice params are updated to be one chunk at a time and to use the next chunk in time (rather than by channel in the case of ecephys).