Change download directory to use cache directory #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I used the home directory because I wanted the downloaded files to persist until manually removed. We want to run the download benchmark once per machine and then run any local benchmarks multiple times. If we move it to the cache directory, then it gets deleted at the end of the run. What if we also change |
Exclude 'downloads' directory from cache deletion.
Collaborator
Author
That's fine by me - added |
rly
reviewed
Nov 8, 2025
rly
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also this...
Otherwise download timing is biased to whether or not home directory is SSD or HDD, unconfigured for similarity to the rest of the suite