Add model_number, model_name, and serial_number to Device

[rly]

Motivation

See NeurodataWithoutBorders/nwb-schema#594

Checklist

• Did you update CHANGELOG.md with your changes?
• Have you checked our Contributing document?
• Have you ensured the PR clearly describes the problem and the solution?
• Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
• Have you checked to ensure that there aren't other open Pull Requests for the same change?
• Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (nwb_schema_2.8.0@1b46014). Learn more about missing BASE report.

Additional details and impacted files

@@                 Coverage Diff                 @@
##             nwb_schema_2.8.0    #1997   +/-   ##
===================================================
  Coverage                    ?   91.93%           
===================================================
  Files                       ?       27           
  Lines                       ?     2715           
  Branches                    ?      708           
===================================================
  Hits                        ?     2496           
  Misses                      ?      145           
  Partials                    ?       74           

Flag	Coverage Δ
integration	72.89% <100.00%> (?)
unit	82.90% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stephprince]

Looks great! Thanks for updating the tutorial examples as well.

If we wanted to be consistent throughout, we could also update the ogen and icephys docs:

pynwb/docs/gallery/domain/ogen.py

Lines 43 to 47 in 084aa55

	device = nwbfile.create_device(
	name="device",
	description="description of device",
	manufacturer="optional but recommended",
	)

pynwb/docs/gallery/domain/icephys.py

Line 55 in 084aa55

device = nwbfile.create_device(name="Heka ITC-1600")

but I don't know if that's really necessary.

[rly]

Looks great! Thanks for updating the tutorial examples as well.

If we wanted to be consistent throughout, we could also update the ogen and icephys docs:

pynwb/docs/gallery/domain/ogen.py

Lines 43 to 47 in 084aa55

	device = nwbfile.create_device(
	name="device",
	description="description of device",
	manufacturer="optional but recommended",
	)

pynwb/docs/gallery/domain/icephys.py

Line 55 in 084aa55

device = nwbfile.create_device(name="Heka ITC-1600")

but I don't know if that's really necessary.

I thought that too but I was not sure what the best example values for those are... do you have any suggestions? We could also punt this to an issue for a later fix.

[stephprince]

I thought that too but I was not sure what the best example values for those are... do you have any suggestions? We could also punt this to an issue for a later fix.

I'm also not sure what the best examples would be... I'm good punting to a separate issue and getting feedback from someone who currently uses those techniques.