Skip to content

Conversation

@rly
Copy link
Contributor

@rly rly commented Mar 4, 2025

Motivation

Fix #2049

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.96%. Comparing base (618df86) to head (03f20ff).
⚠️ Report is 18 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2051      +/-   ##
==========================================
+ Coverage   94.95%   94.96%   +0.01%     
==========================================
  Files          28       28              
  Lines        2832     2840       +8     
  Branches      725      729       +4     
==========================================
+ Hits         2689     2697       +8     
  Misses         87       87              
  Partials       56       56              
Flag Coverage Δ
integration 74.33% <0.00%> (-0.21%) ⬇️
unit 84.82% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rly rly marked this pull request as ready for review March 4, 2025 18:14
@rly rly requested a review from stephprince March 4, 2025 18:14
@stephprince stephprince self-assigned this Jun 27, 2025
@stephprince stephprince added this to the 3.1.0 milestone Jun 27, 2025
@rly
Copy link
Contributor Author

rly commented Jul 8, 2025

Looks good. Thank you @stephprince ! Could you please approve?

@rly rly requested a review from stephprince July 8, 2025 15:21
@rly rly enabled auto-merge (squash) July 8, 2025 15:21
@rly rly merged commit d04c9ab into dev Jul 8, 2025
26 checks passed
@rly rly deleted the ip_descrip branch July 8, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Description of ImagingPlane is required by PyNWB, but not schema

3 participants