Skip to content

Conversation

@stephprince
Copy link
Contributor

@stephprince stephprince commented May 7, 2025

Motivation

Fix #2064.

These changes will update the conditions in which the "ignore cached namespaces" warning is displayed and will only warn for core namespaces if the cached version is newer than the loaded version.

After HDMF 4.1.0 is released, this can be fully tested and merged.

How to test the behavior?

from pynwb import NWBHDF5IO

io = NWBHDF5IO("tests/back_compat/2.1.0_nwbfile_with_extension.nwb", "r")
io.read()  # no warnings should be raised

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented May 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.83%. Comparing base (fef82aa) to head (53fded2).
⚠️ Report is 31 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2077   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files          28       28           
  Lines        2751     2751           
  Branches      708      708           
=======================================
  Hits         2609     2609           
  Misses         82       82           
  Partials       60       60           
Flag Coverage Δ
integration 74.15% <100.00%> (-0.04%) ⬇️
unit 84.84% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephprince stephprince marked this pull request as ready for review June 4, 2025 20:01
@stephprince
Copy link
Contributor Author

@rly this should be ready to review - the test failures should be addressed in #2090, which would ideally be merged first to confirm bumping the HDMF minimum does not cause any other errors.

@stephprince stephprince requested a review from rly June 4, 2025 20:02
@rly rly merged commit dbff399 into dev Jun 5, 2025
26 checks passed
@rly rly deleted the add-core-namespace-to-catalog branch June 5, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Specify core namespace when creating the NamespaceCatalog

3 participants