Skip to content

Conversation

@rly
Copy link
Contributor

@rly rly commented May 29, 2025

Motivation

Fix broken wheel installation in https://github.com/NeurodataWithoutBorders/pynwb/actions/runs/15316694085/job/43091793043

The core problem is that a type map is cached using hdmf 3.14.5 but then the wheel installation happens using hdmf 4.1.0, and in hdmf 4.1.0, we renamed ClassGenerator to ClassGeneratorManager. This breaks the loading of the pickled type map because ClassGenerator does not exist.

To remedy that, we will use both the pynwb and hdmf version to generate the name of the type map cache directory.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented May 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.83%. Comparing base (98a6701) to head (b5b640a).
⚠️ Report is 34 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2087   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files          28       28           
  Lines        2750     2751    +1     
  Branches      708      708           
=======================================
+ Hits         2608     2609    +1     
  Misses         82       82           
  Partials       60       60           
Flag Coverage Δ
integration 74.19% <100.00%> (+<0.01%) ⬆️
unit 84.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rly rly merged commit b6142fa into dev May 29, 2025
64 of 72 checks passed
@rly rly deleted the rly-patch-1 branch May 29, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants