Skip to content

Conversation

@rly
Copy link
Contributor

@rly rly commented May 31, 2025

Motivation

Fix #2043

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented May 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.94%. Comparing base (efbc778) to head (670aa90).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           nwb-schema-2.9.0    #2088      +/-   ##
====================================================
+ Coverage             94.90%   94.94%   +0.03%     
====================================================
  Files                    28       28              
  Lines                  2809     2830      +21     
  Branches                719      724       +5     
====================================================
+ Hits                   2666     2687      +21     
  Misses                   87       87              
  Partials                 56       56              
Flag Coverage Δ
integration 74.59% <75.00%> (-0.03%) ⬇️
unit 84.77% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rly rly requested a review from stephprince June 9, 2025 21:15
Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! A couple minor questions about documentation

@rly rly merged commit ddca692 into nwb-schema-2.9.0 Jun 10, 2025
25 checks passed
@rly rly deleted the device_model branch June 10, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants