-
Notifications
You must be signed in to change notification settings - Fork 90
Add support for EventDetection with channel index #2091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nwb-schema-2.9.0 #2091 +/- ##
====================================================
- Coverage 94.93% 94.90% -0.03%
====================================================
Files 28 28
Lines 2802 2809 +7
Branches 716 719 +3
====================================================
+ Hits 2660 2666 +6
Misses 87 87
- Partials 55 56 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks good. Let's merge the schema PR, update the submodule in this repo, and then merge this PR to the 2.9.0 branch. |
Motivation
Fix #2068. Adds support for nwb-schema changes to EventDetection in NeurodataWithoutBorders/nwb-schema#620
How to test the behavior?
See updated example in the ecephys tutorial.
Checklist
ruff check . && codespellfrom the source directory.