Skip to content

Conversation

@stephprince
Copy link
Contributor

@stephprince stephprince commented Jun 4, 2025

Motivation

Fix #2068. Adds support for nwb-schema changes to EventDetection in NeurodataWithoutBorders/nwb-schema#620

How to test the behavior?

See updated example in the ecephys tutorial.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.90%. Comparing base (87dcadc) to head (d35ecf1).

Files with missing lines Patch % Lines
src/pynwb/ecephys.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           nwb-schema-2.9.0    #2091      +/-   ##
====================================================
- Coverage             94.93%   94.90%   -0.03%     
====================================================
  Files                    28       28              
  Lines                  2802     2809       +7     
  Branches                716      719       +3     
====================================================
+ Hits                   2660     2666       +6     
  Misses                   87       87              
- Partials                 55       56       +1     
Flag Coverage Δ
integration 74.61% <28.57%> (-0.12%) ⬇️
unit 84.65% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephprince stephprince marked this pull request as ready for review June 5, 2025 17:34
@stephprince stephprince requested a review from rly June 5, 2025 17:34
@rly
Copy link
Contributor

rly commented Jun 8, 2025

Looks good. Let's merge the schema PR, update the submodule in this repo, and then merge this PR to the 2.9.0 branch.

@stephprince stephprince merged commit efbc778 into nwb-schema-2.9.0 Jun 9, 2025
25 checks passed
@stephprince stephprince deleted the add-ch-idx-to-event-detection branch June 9, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants