Skip to content

Conversation

@stephprince
Copy link
Contributor

@stephprince stephprince commented Jun 13, 2025

Motivation

Related to nwb-schema changes in NeurodataWithoutBorders/nwb-schema#635. Add deprecation warning for EventDetection.times

How to test the behavior?

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.95%. Comparing base (ddca692) to head (39f5851).

Additional details and impacted files
@@                Coverage Diff                @@
##           nwb-schema-2.9.0    #2101   +/-   ##
=================================================
  Coverage             94.94%   94.95%           
=================================================
  Files                    28       28           
  Lines                  2830     2832    +2     
  Branches                724      725    +1     
=================================================
+ Hits                   2687     2689    +2     
  Misses                   87       87           
  Partials                 56       56           
Flag Coverage Δ
integration 74.54% <0.00%> (-0.06%) ⬇️
unit 84.78% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephprince stephprince marked this pull request as ready for review June 13, 2025 00:42
@stephprince stephprince requested a review from rly June 13, 2025 00:42
@stephprince stephprince merged commit db29bbf into nwb-schema-2.9.0 Jun 16, 2025
25 checks passed
@stephprince stephprince deleted the deprecate-eventdetection-times branch June 16, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants