Skip to content

Conversation

@rly
Copy link
Contributor

@rly rly commented Jul 13, 2025

Motivation

Fix hdmf-dev/hdmf-zarr#281

How to test the behavior?

I added a backwards compatibility test with an NWB file written with PyNWB 3.0.0 with a Units table that points to the (old) electrodes table and an ElectricalSeries that points to the (old) electrodes table

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Jul 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.31%. Comparing base (e1d0612) to head (1916d9f).
⚠️ Report is 14 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2112      +/-   ##
==========================================
+ Coverage   95.21%   95.31%   +0.10%     
==========================================
  Files          28       28              
  Lines        2840     2837       -3     
  Branches      729      730       +1     
==========================================
  Hits         2704     2704              
+ Misses         80       77       -3     
  Partials       56       56              
Flag Coverage Δ
integration 74.40% <100.00%> (+0.07%) ⬆️
unit 85.26% <73.91%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rly rly requested a review from stephprince July 13, 2025 23:02
@rly rly enabled auto-merge (squash) July 14, 2025 01:12
@rly rly disabled auto-merge July 16, 2025 04:02
stephprince
stephprince previously approved these changes Jul 16, 2025
@rly rly enabled auto-merge (squash) July 16, 2025 04:14
@rly rly requested a review from stephprince July 16, 2025 05:57
@rly rly merged commit ec3d0f0 into dev Jul 16, 2025
26 checks passed
@rly rly deleted the fix_electrodes_export branch July 16, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Documentation]: sphinx-gallery tests failing due to electrodes not build error on export

3 participants