get_nwbfile_version/get_nwb_version: Fix parsing pre-semver version specifiers #2118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2118 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 28 28
Lines 2845 2846 +1
Branches 735 735
=======================================
+ Hits 2712 2713 +1
Misses 77 77
Partials 56 56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
t-b
force-pushed
the
ignore-nwb-prefix-in-version
branch
from
48f6cb1 to
35eb2de
Compare
…pecifiers In commit NeurodataWithoutBorders/nwb-schema@dba02ff (update YAML specs with 2.1.0 specs, 2019-08-19) the help for nwb_version was changed in the following regard: --- a/core/nwb.file.yaml +++ b/core/nwb.file.yaml @@ -2,220 +2,231 @@ groups: [...] - name: nwb_version dtype: text - doc: 'File version string. COMMENT: Eg, NWB-1.0.0. This will be the name of the - format with trailing major, minor and patch numbers.' - value: 2.0b + value: 2.0.2 + doc: File version string. Use semantic versioning, e.g. 1.2.1. This will be the + name of the format with trailing major, minor and patch numbers. While adopting semantic versioning for nwb_version is a good step, care needs to be taken to allow reading older files. Versions of IPNWB prior to AllenInstitute/IPNWB@70c65d4 (Switch to newer NWB specification 2.2.4, 2020-04-15) did follow the old suggestion in prefixing nwb_version with `NWB-`. Let's disregard that prefix as was previsously done with the suffix 'b' in 26538b3 (Fix handling of version 2.0b (NeurodataWithoutBorders#1651), 2023-02-24).
t-b
force-pushed
the
ignore-nwb-prefix-in-version
branch
from
35eb2de to
ca4faea
Compare
5 tasks
stephprince
reviewed
Jul 31, 2025
stephprince
approved these changes
Jul 31, 2025
Contributor
stephprince
left a comment
stephprince
left a comment
There was a problem hiding this comment.
LGTM, thanks @t-b! To summarize, NWB files created after 2.0.2 should use semantic versioning, but these changes will allow files using the older NWB- prefix to be read
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit NeurodataWithoutBorders/nwb-schema@dba02ff (update YAML specs with 2.1.0 specs, 2019-08-19) the help for nwb_version was changed in the following regard:
While adopting semantic versioning for nwb_version is a good step, care needs to be taken to allow reading older files.
Versions of IPNWB prior to AllenInstitute/IPNWB@70c65d4 (Switch to newer NWB specification 2.2.4, 2020-04-15) did follow the old suggestion in prefixing nwb_version with
NWB-.Let's disregard that prefix as was previsously done with the suffix 'b' in 26538b3 (Fix handling of version 2.0b (#1651), 2023-02-24).
Close #2117