Remove "testing" from TestImportStructure #2136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I found this strange behavior today.
pytest tests/back_compat/test_import_structure.pyfails with errorAssertionError: 'testing' not found in ['BuildManager', 'CORE_NAMESPACE', ...because
testingis not part of thepynwbmodule when you run justimport pynwb. That's correct.However, this test succeeds when we run the full test suite (
pytestorpython test.py) because other tests havefrom pynwb.testing import TestCasewhich addstestingto thepynwbmodule.So the
test_import_structuretest should be corrected to not include "testing" in the checks because it is technically not part of thepynwbmodule.How to test the behavior?
Checklist
ruff check . && codespellfrom the source directory.