feat(retrieve): add scoped reference-aware RAG recall - #479
Open
COMPRyanLI wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Adds opt-in reference-aware item retrieval to RAG while preserving the existing
vector-only default and the public
retrieve()response shape.What does this PR do?
[ref:...]citationslist_items_by_ref_ids()repository lookupitem.top_k, includingtop_k=0Why is this change needed?
Vector similarity can miss an exact memory item already cited by a relevant category.
Following those citations provides deterministic recall without introducing an
unconditional item scan or changing the public retrieval API.
On a deterministic three-query synthetic benchmark:
These are synthetic benchmark results, not a production-wide quality claim.
Closes #478
Type of Change
PR Quality Checklist
Optional
Validation
Passed from a clean worktree containing only this commit:
uv lock --lockeduv run pre-commit run -auv run mypyuv run deptry srcCaveats
ref_idvalues inside one scope return all distinct matching items