Skip to content

test(documents,reports): register S3Service and FeeRevenueController, reorganize feature specs, add missing unit coverage - #1185

Merged
portableDD merged 1 commit into
Nexacore-Org:mainfrom
demilade18-git:feature/demilade18-git-fixes
Aug 30, 2026
Merged

test(documents,reports): register S3Service and FeeRevenueController, reorganize feature specs, add missing unit coverage#1185
portableDD merged 1 commit into
Nexacore-Org:mainfrom
demilade18-git:feature/demilade18-git-fixes

Conversation

@demilade18-git

@demilade18-git demilade18-git commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Addresses the four issues assigned to this account.

Closes #1137
Closes #1138
Closes #1139
Closes #1140

@demilade18-git
test(documents,reports): register S3Service and FeeRevenueController,…
b4fb6ff 
… reorganize feature specs, add missing unit coverage

- documents: register S3Service as a provider so it is instantiable
- reports: add a module for the orphaned FeeRevenueController and register it in AppModule
- specs: move the seven top-level contributor-named feature specs into their owning modules
- scheduled-reports: add unit coverage for NotificationPreferencesService, ScheduledReportsService, and TermsController

Closes Nexacore-Org#1137, Nexacore-Org#1138, Nexacore-Org#1139, Nexacore-Org#1140
@drips-wave

drips-wave Bot commented Aug 30, 2026

Copy link
Copy Markdown

@demilade18-git Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@portableDD
portableDD merged commit 2a94a4b into Nexacore-Org:main Aug 30, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment