feat(scheduled-reports): add execution engine that consumes nextRunAt - #1187
Merged
Merged
Conversation
A minute-level job (@Cron) picks up active scheduled reports whose nextRunAt has passed, invokes generateReport, and advances the schedule via computeNextRun. nextRunAt is no longer computed-but-unconsumed. Closes Nexacore-Org#1141
|
@BigBen-7 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the four issues assigned to this account.
#1141 — scheduled reports execution engine
Added a minute-level cron job to ScheduledReportsService that queries for active reports whose nextRunAt has passed, calls generateReport, and advances the schedule. nextRunAt is no longer computed-but-unconsumed.
#1142 — configuration.ts missing closing brace (already fixed)
Verified on main: brace balance is 0 across the entire file — no unmatched braces. No code change required.
#1143 — transactions.controller.ts duplicate class (already fixed)
Verified on main: the live file at src/transactions/transactions.controller.ts contains exactly one export class TransactionsController. No code change required.
#1144 — wallets.service.ts stray extra closing brace (already fixed)
Verified on main: brace balance is 0 across the entire file — no unmatched braces. No code change required.
Closes #1141
Closes #1142
Closes #1143
Closes #1144