Skip to content

ISSUE-449: Initial pass at creating 4 and 8 bit branches for the decoder feed#529

Open
herbenderbler wants to merge 3 commits into
Next-Flip:devfrom
herbenderbler:ISSUE-449/show-more-signal-detail
Open

ISSUE-449: Initial pass at creating 4 and 8 bit branches for the decoder feed#529
herbenderbler wants to merge 3 commits into
Next-Flip:devfrom
herbenderbler:ISSUE-449/show-more-signal-detail

Conversation

@herbenderbler
Copy link
Copy Markdown

@herbenderbler herbenderbler commented Mar 8, 2026

What's new

  • ISSUE-449: I added more contextual information in SubGHz decode and history for Princeton 24-bit by adding Chuango-style command labels along with a dedicated one-line history string.

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

Additional info

This PR is contingent upon #530 (and/or additional flash reclamation work) landing

@WillyJL
Copy link
Copy Markdown
Member

WillyJL commented Mar 8, 2026

i like this concept, this is another reason why get_string_brief was added here downstream. there is an argument to be had on whether this flash space is better used for this kind of extra info or for more space for more protocols. in any case i cant in good faith consider merging this until #530 is in (or we free some flash some other way, we are critically low).

@herbenderbler
Copy link
Copy Markdown
Author

i like this concept, this is another reason why get_string_brief was added here downstream. there is an argument to be had on whether this flash space is better used for this kind of extra info or for more space for more protocols. in any case i cant in good faith consider merging this until #530 is in (or we free some flash some other way, we are critically low).

That makes sense. While I'll obviously continue tracking PR #530, I'm curious if I could possibly assist by:

As it seems my work here was received positively, how would you prefer I move forward with it? Should I keep it open until flash is in a better state, until #530 lands, etc.?

All of that being said, I'd really LOVE to contribute somewhere in Momentum with more impact. Any guidance you can offer around future contributions and/or this PR would be greatly appreciated ❤️

@herbenderbler herbenderbler changed the title initial pass at creating 4 and 8 bit branches for the decoder feed ISSUE-449: Initial pass at creating 4 and 8 bit branches for the decoder feed Mar 8, 2026
@herbenderbler herbenderbler marked this pull request as ready for review March 9, 2026 17:32
@WillyJL
Copy link
Copy Markdown
Member

WillyJL commented Mar 10, 2026

from a quick look your code seems fine, i wouldnt worry about shrinking it. i was just mentioning that in general we're low on flash, thats something that i inevitably have to get fixed at some point, i didnt mean that this pr had to be done different.

id say keep this open and if you intended to implement something like this for some other protocol go ahead and add it in here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants