ISSUE-449: Initial pass at creating 4 and 8 bit branches for the decoder feed#529
ISSUE-449: Initial pass at creating 4 and 8 bit branches for the decoder feed#529herbenderbler wants to merge 3 commits into
Conversation
…t princeton variants
…ames; 8-bit chuango frames get_string adds a cmd and cmd id line
|
i like this concept, this is another reason why |
That makes sense. While I'll obviously continue tracking PR #530, I'm curious if I could possibly assist by:
As it seems my work here was received positively, how would you prefer I move forward with it? Should I keep it open until flash is in a better state, until #530 lands, etc.? All of that being said, I'd really LOVE to contribute somewhere in Momentum with more impact. Any guidance you can offer around future contributions and/or this PR would be greatly appreciated ❤️ |
|
from a quick look your code seems fine, i wouldnt worry about shrinking it. i was just mentioning that in general we're low on flash, thats something that i inevitably have to get fixed at some point, i didnt mean that this pr had to be done different. id say keep this open and if you intended to implement something like this for some other protocol go ahead and add it in here too. |
What's new
For the reviewer
Additional info
This PR is contingent upon #530 (and/or additional flash reclamation work) landing