chore(aws): remove dead EXECUTOR code from iam.py and s3.py#656
Merged
chore(aws): remove dead EXECUTOR code from iam.py and s3.py#656
Conversation
Remove unused `EXECUTOR = concurrent.futures.ThreadPoolExecutor(10)` and `from tornado import concurrent` from both files. These constants were defined for `@run_on_executor` but no method in either file uses that decorator — all IAM/S3 actors inherit `api_call()` from `AWSBaseActor` which has its own executor. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
LaikaN57
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EXECUTOR = concurrent.futures.ThreadPoolExecutor(10)andfrom tornado import concurrentfromactors/aws/iam.pyandactors/aws/s3.py@run_on_executorbut no method in either file uses that decorator — all IAM/S3 actors inheritapi_call()fromAWSBaseActorwhich has its own executorTest plan
make testpasses (361 tests, 0 failures)Part 1 of 10 in the tornado removal migration.
🤖 Generated with Claude Code