View Integration for View Loadout Group Files #3171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce Diff View also uses them True story!
Seems I had the test borked, when I wrote the original code, oopsie!
Just need to fix some XAML, and off we go to Diff view
Fixed: Accidental errors in previous styles commit
… to the parent datom. Changed: Filter by LoadoutFile directly, skipping a type check.
…r, as this is no longer necessary.
…adoutGroupFilesProvider
…ease memory on context switch.
…ble disposal via wrapper.
… request in review.
This reverts commit 4bb2581. So we can use GamePath as key for folder generator
|
This PR doesn't conflict with |
…files. Update return values for Delete methods
… parent folder name and fix some tests
…ed by the TreeAdapter later on, and this would dispose them while they are still being used.
…, next to the file model creation
…button to the new view model
…r consistency with other view models
…e structure used for other pages
Al12rs
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles the PR feedback from
To be reviewed after above PR.
This contains the remaining view integration; however is not in a mergeable state due to external issues unrelated to the code.
EDIT (Al12rs):
Did a number of fixes and changes:
LoadoutItemGroupFileTreeViewModelafter moving out utility function still in use to new VMItemContentsFileTreepage/view/vm etcViewLoadoutGroupFilesTreeDataGridAdapterintoLoadoutGroupFilesViewModelLoadoutGroupFilesTreeFolderModelInitializerintoLoadoutGroupFilesProviderRemaining items:
Hoping @insomnious can have a look at these:
EDIT: will be done in separate PR
Indents are broken when sorting
After sorting the indents remain on the same row as before, leading to regular files getting indented.
This will need a hand from @insomnious .