Skip to content

Fix collection rating parsing #3187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

Fix collection rating parsing #3187

merged 1 commit into from
May 19, 2025

Conversation

erri120
Copy link
Member

@erri120 erri120 commented May 14, 2025

Some API endpoints return values between 0 and 100, others between 0 and 1. We previously used the latter which didn't work when switching to the former that resulted in always showing 100%.

Resolves #2370.

@erri120 erri120 requested a review from a team May 14, 2025 08:39
@erri120 erri120 self-assigned this May 14, 2025
@erri120 erri120 added this to MVP May 14, 2025
@erri120 erri120 moved this to Review in MVP May 14, 2025
Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am not qualified to comment on these endpoints but I'll trust your word

Some API endpoints return values between 0 and 100, others between 0 and
1. We previously used the latter which didn't work when switching to the
former that resulted in always showing 100%.
@erri120 erri120 merged commit 39b2f58 into Nexus-Mods:main May 19, 2025
11 checks passed
@erri120 erri120 deleted the fix/2370 branch May 19, 2025 11:05
@github-project-automation github-project-automation bot moved this from Review to Done in MVP May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Change revision percentage on collection download page
2 participants