Skip to content

More http download fixes #3193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 19, 2025
Merged

Conversation

erri120
Copy link
Member

@erri120 erri120 commented May 14, 2025

  • Use default HTTP client config
  • Add retry on network exceptions
  • Add setting to control max parallel download count for collections

@erri120 erri120 requested a review from a team May 14, 2025 14:08
@erri120 erri120 self-assigned this May 14, 2025
@erri120 erri120 added this to MVP May 14, 2025
@erri120 erri120 moved this to Review in MVP May 14, 2025
@erri120 erri120 changed the title Add more logging and use default HTTP client config More http download fixes May 15, 2025
@erri120 erri120 added the backport candidate Ticket or PR that might need inclusion in the Release Candidate due to severity label May 15, 2025
@erri120 erri120 force-pushed the fix/download-issues branch from ae64c12 to f14ee06 Compare May 15, 2025 09:53
@Al12rs
Copy link
Contributor

Al12rs commented May 15, 2025

I tried with manually setting 50 as parallelism level on a wifi connection (~150mbs) and it completed fine

@Al12rs Al12rs mentioned this pull request May 19, 2025
@Al12rs
Copy link
Contributor

Al12rs commented May 19, 2025

I'm going to merge despite the CI errors since all the run failures were recognized as known flaky tests

@Al12rs Al12rs merged commit f6cbdbd into Nexus-Mods:main May 19, 2025
13 of 21 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in MVP May 19, 2025
@erri120 erri120 deleted the fix/download-issues branch May 19, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport candidate Ticket or PR that might need inclusion in the Release Candidate due to severity
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants